Nicholas Brunoro

Results 8 comments of Nicholas Brunoro

I've never heard of a Check Spelling job. What am I supposed to do to fix it? Do I do something outlined here? https://github.com/firecamp-dev/firecamp/actions/runs/6540867134/attempts/1#summary-17761524652

> Add `^\Qpackages/firecamp-echo-server/src/assets/unicodedemo.html\E$` to `.github/actions/spelling/excludes.txt` helped with a lot of the issues thanks. Still getting some though ```fgj Gzna RKC rpaxn ruxnpa rxn Streamable Successfull unicodedemo werxhqb xrunpaw ``` Doesn't...

Cleaned up the PR and fixed the spelling for the spelling jobs.

> @nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores. Yeah it's ready for review now. I'll update...

> I have one question, Have you cross-checked echo server APIs from the PM collection? Any APIs are pending to be implemented in FC? please confirm :) I cross checked...

> Hi @nkBrew, do you have a plan to finish pending routes in the coming days? @Nishchit14 Yeah, was able to do it. Just uploaded the changes.

I'd like to work on this. To clarify, what still needs to be done? The methods that return `yet to implement` or is there more?

@Nishchit14 Yeah, sorry was working on it locally. Got most of the auth stuff done and cookies. https://github.com/nkBrew/firecamp/blame/EchoServer/packages/firecamp-echo-server/src/rest/rest.controller.ts Edit: Also I know there's some stuff to clean up. That's why...