firecamp icon indicating copy to clipboard operation
firecamp copied to clipboard
verified publisher icon firecamp-dev

feat: Echo server

Open nkBrew opened this issue 2 years ago • 14 comments

Description: Implemented controllers that implement the same functionality for Postman's echo server

The controllers in question cover Auth

  • basic
  • digest
  • hawk
  • oauth1.0

Cookies

  • set
  • get
  • delete

Utilities

  • stream
  • encoding/utf8
  • gzip
  • deflate
  • ip

Time

  • now
  • valid
  • format
  • extract
  • subtract
  • start
  • before
  • after
  • between
  • leapyear

Notes: - I still have a bit of cleanup I want to do to deduplicate some stuff. Wanted to get the PR up for review though.

  • I didn't do much Typescripting as when I came in most of the project wasn't using it.
  • Tried using dayjs for the time, but theres a typescript bug that's been there for a year. If you feel this is ok let me know and I'll switch it to dayjs https://github.com/iamkun/dayjs/issues/1897#issuecomment-1804091178

Closes: #106

nkBrew avatar Oct 17 '23 00:10 nkBrew

Deploy request for staging-firecamp-dev rejected.

Name Link
Latest commit ed0f1f9d7ca91f394a76a3c07aced616e4052f9b

netlify[bot] avatar Oct 17 '23 00:10 netlify[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 17 '23 00:10 CLAassistant

I've never heard of a Check Spelling job. What am I supposed to do to fix it?

Do I do something outlined here? https://github.com/firecamp-dev/firecamp/actions/runs/6540867134/attempts/1#summary-17761524652

nkBrew avatar Oct 17 '23 00:10 nkBrew

Add ^\Qpackages/firecamp-echo-server/src/assets/unicodedemo.html\E$ to .github/actions/spelling/excludes.txt

jsoref avatar Oct 17 '23 02:10 jsoref

Add ^\Qpackages/firecamp-echo-server/src/assets/unicodedemo.html\E$ to .github/actions/spelling/excludes.txt

helped with a lot of the issues thanks.

Still getting some though

Gzna
RKC
rpaxn
ruxnpa
rxn
Streamable
Successfull
unicodedemo
werxhqb
xrunpaw

Doesn't seem to like the keys. I can fix that by moving them to a separate file and ignoring that as well. Don't really know how to fix Streamable and unicodedemo though. Those are kindof required.

nkBrew avatar Oct 17 '23 14:10 nkBrew

Cleaned up the PR and fixed the spelling for the spelling jobs.

nkBrew avatar Oct 23 '23 00:10 nkBrew

@nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores.

Nishchit14 avatar Oct 25 '23 12:10 Nishchit14

@nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores.

Yeah it's ready for review now. I'll update the description

nkBrew avatar Oct 26 '23 17:10 nkBrew

will try it this weekend!!

Nishchit14 avatar Oct 28 '23 07:10 Nishchit14

I have one question, Have you cross-checked echo server APIs from the PM collection? Any APIs are pending to be implemented in FC? please confirm :)

I cross checked the API endpoints that had return yet to be implemented on them with the Postman echo collection. I can double check later today if there are some missing.

nkBrew avatar Nov 02 '23 15:11 nkBrew

sure @nkBrew take your time :)

Nishchit14 avatar Nov 03 '23 05:11 Nishchit14

Hi @nkBrew, do you have a plan to finish pending routes in the coming days?

Nishchit14 avatar Nov 10 '23 07:11 Nishchit14

Hi @nkBrew, do you have a plan to finish pending routes in the coming days?

@Nishchit14 Yeah, was able to do it. Just uploaded the changes.

nkBrew avatar Nov 12 '23 20:11 nkBrew

@nkBrew thank you for the update, eager to deploy the echo server on the production server :)

Nishchit14 avatar Nov 13 '23 14:11 Nishchit14