Nizar Benalla

Results 36 comments of Nizar Benalla

> I think your changes mostly group in these categories: > > 1. New API methods provided in superclasses/superinterfaces, this class provides a more concrete implementation: > Examples being `CompletableFuture`,...

Recent [offline] discussions have showed that dealing with `@since` in overriding methods is complicated. The solution is to add an explicit `@since` to **some** overriding methods that do not have...

- We will effectively enforce javadoc comment for some method overrides with the checker (we want to match the rules for `javadoc` tool which doesn't have any special handing for...

> > We will effectively enforce javadoc comment for some method overrides with the checker > > Those overriding methods don't even appear on the javadoc output. If you go...

When I said "For overriding methods we don't look into the supertype" I meant my checker tool doesn't do that. > It seems you have some trouble understanding that overriding...

I will run `make docs-jdk-api` before and after making changes, and compare the directories before opening. Might include the info in the PR body.

Thanks, I read those two links yesterday and was thinking of which project lead to mail to be added to the census. Will do so.