jdk
jdk copied to clipboard
8332071: Convert package.html files in `java.management.rmi` to package-info.java
Please review this change. I converted the package.html file to package-info.java, because javac cannot recognize package.html.
I already brought this up in the mailing list.
The conversion was done in-place, only renaming it in git.
I also added a couple of @since tags, with only 2 changes I don't want to split these two fixes into separate PRs.
CREDENTIALS_FILTER_PATTERN and SERIAL_FILTER_PATTERN were first added in https://bugs.openjdk.org/browse/JDK-8187556
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issues
- JDK-8332071: Convert package.html files in
java.management.rmito package-info.java (Sub-task - P4) - JDK-8332376: Add
@<!---->sincetags tojava.management.rmi(Sub-task - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19263/head:pull/19263
$ git checkout pull/19263
Update a local copy of the PR:
$ git checkout pull/19263
$ git pull https://git.openjdk.org/jdk.git pull/19263/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19263
View PR using the GUI difftool:
$ git pr show -t 19263
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19263.diff
Webrev
:wave: Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@nizarbenalla This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332071: Convert package.html files in `java.management.rmi` to package-info.java
8332376: Add `@since` tags to `java.management.rmi`
Reviewed-by: kevinw, rriggs
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 108 new commits pushed to the master branch:
- 9ca90ccd6bfec76e54e2e870bd706fad5abf233c: 8332610: Remove unused nWakeups in ObjectMonitor
- 92d33501e091bdfaab52886078053b849a5a8f68: 8331920: ubsan: g1CardSetContainers.inline.hpp:266:5: runtime error: index 2 out of bounds for type 'G1CardSetHowl::ContainerPtr [2]' reported
- 4f1a10f84bcfadef263a0890b6834ccd3d5bb52f: 8332360: JVM hangs at exit when running on a uniprocessor
- c3bc23fe48ca1603afe68a6ac4aaa523a1edbb41: 8326306: RISC-V: Re-structure MASM calls and jumps
- 8a9d77d58de259b6b2bdc2cc9e7bfdc28dcf7165: 8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms
- 3d511ff63e59f542ae20c722bfef1c867cd1da0e: 8329748: Change default value of AssertWXAtThreadSync to true
- 67f03f2a4f5ac12748ffbf5c04f248a60869e180: 8332533: RISC-V: Enable vector variable shift instructions for machines with RVV
- 5f804b2ec12627b593353ceeab881187b0bb5cd6: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER
- 52eda79522a5bd71b527e5946b654a331b021473: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
- d999b81e7110751be402012e1ed41b3256f5895e: 8331572: Allow using OopMapCache outside of STW GC phases
- ... and 98 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinjwalls, @RogerRiggs) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@nizarbenalla The following labels will be automatically applied to this pull request:
jmxserviceability
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
/issue add JDK-8332286
@nizarbenalla
Adding additional issue to issue list: 8332286: Fix the @since tags in java source code documentation.
sorry about the force push, had to.
/issue add JDK-8332376
/issue remove JDK-8332286
@nizarbenalla
Adding additional issue to issue list: 8332376: Add @sincetags tojava.management.rmi``.
@nizarbenalla
Removing additional issue from issue list: 8332286.
/label remove jmx
@nizarbenalla
The jmx label was successfully removed.
Webrevs
- 04: Full - Incremental (82536dd9)
- 03: Full - Incremental (393bf3a3)
- 02: Full - Incremental (232a533a)
- 01: Full - Incremental (e2471645)
- 00: Full (52d3d182)
/reviewers 2
@kevinjwalls The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).
/integrate
@nizarbenalla Your change (at version 82536dd9d50c20fd8120d388c0254168e6c91e82) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit a0c5714dbc8a60d905f9deea153e7f31fbd64d06.
Since your change was applied there have been 109 commits pushed to the master branch:
- afed7d0b0593864e5595840a6b645c210ff28c7c: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic
- 9ca90ccd6bfec76e54e2e870bd706fad5abf233c: 8332610: Remove unused nWakeups in ObjectMonitor
- 92d33501e091bdfaab52886078053b849a5a8f68: 8331920: ubsan: g1CardSetContainers.inline.hpp:266:5: runtime error: index 2 out of bounds for type 'G1CardSetHowl::ContainerPtr [2]' reported
- 4f1a10f84bcfadef263a0890b6834ccd3d5bb52f: 8332360: JVM hangs at exit when running on a uniprocessor
- c3bc23fe48ca1603afe68a6ac4aaa523a1edbb41: 8326306: RISC-V: Re-structure MASM calls and jumps
- 8a9d77d58de259b6b2bdc2cc9e7bfdc28dcf7165: 8320622: [TEST] Improve coverage of compiler/loopopts/superword/TestMulAddS2I.java on different platforms
- 3d511ff63e59f542ae20c722bfef1c867cd1da0e: 8329748: Change default value of AssertWXAtThreadSync to true
- 67f03f2a4f5ac12748ffbf5c04f248a60869e180: 8332533: RISC-V: Enable vector variable shift instructions for machines with RVV
- 5f804b2ec12627b593353ceeab881187b0bb5cd6: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER
- 52eda79522a5bd71b527e5946b654a331b021473: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
- ... and 99 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master
Your commit was automatically rebased without conflicts.
@kevinjwalls @nizarbenalla Pushed as commit a0c5714dbc8a60d905f9deea153e7f31fbd64d06.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.