Niels de Vos

Results 240 comments of Niels de Vos

@phlogistonjohn you can assign this to @ansiwen as he is looking into this.

Explicitly closing the image in case it is still open would be hiding the issue. I prefer to have an additional check like `imageIsClosed`: ```golang if err := image.validate(imageNeedsIOContext |...

See also #153 for similar problems when calling librbd functions on an image that is closed.

On Mon, Dec 30, 2019 at 09:55:57AM -0800, Camilo Schöningh wrote: > Is this what you mean ;-) https://github.com/torvalds/linux/blob/master/include/linux/ceph/libceph.h These are Linux kernel functions that can not simply be called...

I do not like duplicating the work done in the `rbd` command. There are also options for krbd and ndb-rbd, so it would be required to (re)implement both ways. @dillaman...

A release process and some planning would be good to have. #75 and #92 are related to that. What would be needed to get an initial version tagged/branched?

I'm happy to help out with reviewing, and other maintenance tasks for this repo. Thanks!

One of the goals listed in the description of this issue is: - Aim for 100% test coverage (according to golang native coverage tool) This does not seem possible for...

> How about reworking that bullet as, "Aim for coverage of all code paths, including error handling, that can be reasonably tested in the unit test framework." It's a lot...

@phlogistonjohn I'd like to exclude one set of APIs, as they are rather difficult to implement and need more thinking/testing than is required for a 1st release. Anything that has...