Niels de Vos

Results 518 comments of Niels de Vos

Yes, standardization on logging format would be nice. I prefer the format like `"failed to do something: %w", err`, not including the string `with error:`. For cases where errors are...

Please split the vendor part from the actual feature, that makes it much easier to review.

https://github.com/ceph/ceph-csi/pull/2343#issuecomment-891825471 failed again ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.19/detail/mini-e2e-helm_k8s-1.19/2298/pipeline))

https://github.com/ceph/ceph-csi/pull/2308#issuecomment-891856084 failed here too ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.20/detail/mini-e2e_k8s-1.20/1908/pipeline))

https://github.com/ceph/ceph-csi/pull/2354#issuecomment-892400000 as well ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.20/detail/mini-e2e-helm_k8s-1.20/1902/pipeline/))

failed in https://github.com/ceph/ceph-csi/pull/2350#issuecomment-892500553 too ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.21/detail/mini-e2e_k8s-1.21/589/pipeline)

https://github.com/ceph/ceph-csi/pull/2341#issuecomment-892516420 hit this too ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.19/detail/mini-e2e_k8s-1.19/2363/pipeline))

https://github.com/ceph/ceph-csi/pull/2322#issuecomment-892634477 hit this ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.21/detail/mini-e2e_k8s-1.21/608/pipeline))

> @nixpanic as we are hitting frequently is it a good idea to add a wrapper to retry? I don't know. There is already an automated retry by minikube. We...

https://github.com/ceph/ceph-csi/pull/2341#issuecomment-892773815 as well ([logs](https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/upgrade-tests-cephfs/detail/upgrade-tests-cephfs/2566/pipeline))