Animesh Rawat

Results 21 comments of Animesh Rawat

sorry for acting late on this issue ,my exams just got over.

@EwoutH do we also need a component to track the seed state,read discussion from @quaquel in #2496 regarding this.

how does this look -- ## seed when set random ![Image](https://github.com/user-attachments/assets/8f6a3730-99cd-429a-aaa0-f8184f0c0930) ## seed changed manually ![Image](https://github.com/user-attachments/assets/5f9ce3cd-c8b7-4590-acf0-9d1dbeb5b948) @quaquel @EwoutH @Corvince how is this checkbox type design?

@tpike3 When I run the tests locally, they don't fail, but they are failing here. ![image](https://github.com/user-attachments/assets/5b80d9c7-59a0-40c4-b0ca-d3a899be8e61)

> > @tpike3 When I run the tests locally, they don't fail, but they are failing here. > > ![image](https://private-user-images.githubusercontent.com/131552285/406837142-5b80d9c7-59a0-40c4-b0ca-d3a899be8e61.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzc5NzU1MzUsIm5iZiI6MTczNzk3NTIzNSwicGF0aCI6Ii8xMzE1NTIyODUvNDA2ODM3MTQyLTViODBkOWM3LTU5YTAtNDBjNC1iMGNhLWQzYTg5OWJlOGU2MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEyN1QxMDUzNTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMGEyZTM0MzU0ZmI1YjkzYzk1MmVmMTAwMjgzOWE3NDM4NzExYzY3N2U2ZTU5MzJkYWJkMWRmZTlhYTA0NmI3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.nE9aK7v-fN4Lb-kzUDkWkpS7siXT8e5Znabz0vbMzLo) > > I am not sure why your tests are...

@quaquel @tpike3 i was making a generic get_agent_data function ,should i remove all the old functions like _get_agent_data_new_discrete_space or keeping them will be right?

@quaquel i have added all the stuff,can you review it?

@tpike3 For now, there haven't been many conflicts with #2641. I have also talked to @sanika-n regarding possible overlaps ,will be looking forward for your review.

> I suggest we try to merge this PR first, then rebase #2643 and merge that afterward. @nissu99, @sanika-n do you both agree? > > My motivation is that this...