Animesh Rawat
Animesh Rawat
> Can you elaborate on the "other fixes" from the title? Nothing much ,it was for renaming and adding the generic method , i should have named it better.
> @nissu99 Thanks for making some changes already! Could you share the state of this PR and preferably reply to the review comments (of quaquel) individually? > > @Sahil-Chhoker this...
> @nissu99 can you give an indication of your timeline? We might otherwise merge some other altair PR first. As you had pointed out, I was seeing if a common...
@quaquel what do you say should I focus on that or just make other changes and will make a future PR for the Common function?
> This PR is already an improvement. The logical next step, which ideally would be part of this PR, is to structure the code exactly as done for matplotlib. This,...
> @nissu99 I have done a basic overview of functioning of the `altair` drawing system, if you find similar problems please fix them. I will do a thorough review on...
@quaquel @Sahil-Chhoker I think we should keep the core API very concise, and changes like controlling grid visibility can be handled in the post-processing stage, what is your opinion?
@Sahil-Chhoker can you share the example you are using?
can i work on this?
@quaquel @EwoutH should i include an example using altair plot?