Nir Soffer

Results 341 comments of Nir Soffer

#4221 seems to be the root cause. This is backward incompatible change (as the PR claim): https://github.com/lima-vm/lima/pull/4221/commits/4d04ff373b7d47105688c2424053eb4ae04ca67d#diff-e9ced80afbf7de8678a2483dce1448551731173b533ec60bdca549cfc7baa194 The the docs for ignoring the port forwards were not updated to show...

> > thanks for the PR, please update the before/after (it seems to be outdated) > > updated! It is still outdated: > They are now moved into a dedicated...

@henry3260 this change broke few test: ``` === RUN TestDownloadOnly/v1.28.0/binaries aaa_download_only_test.go:157: expected the file for binary exist at "/home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubelet" but got error stat /home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubelet: no such file or directory aaa_download_only_test.go:157:...

It is possible that the test was broken before this change. To be sure please share complete test command and output with master showing the failures. We meed to fix...

@henry3260 looking in the test is does not disable preloads, and it checks if reload exists after starting minikube. If the preload tarball exists it does check for binaries. If...

> I dont think there is urgency in removing this driver, we can continue warn and also remove it from being listed or advertised. I actually do have mac device...