Nir Soffer
Nir Soffer
> Follows up on issue #21483. This should be: Fixes #21483 Which will link this PR to the issue. When we merge the issue will be closed automatically.
@shubhanshu-02 thanks! @medyagh merge?
Looks like systemd problem, not vdsm. Also this is very old and inactive issue, maybe close?
> cc [@nirs](https://github.com/nirs) Do you plan to work on this ? Yes. Regarding the propose solutions: > ## Option 1: port vmnet-helper improvements to socket_vmnet I don't think this can...
> ## Testing > * go test ./... > * golangci-lint run --concurrency 1 ./... Unfortunately this is not enough - you need to run a real cluster with port...
@casey-quinn this change is way too big for a bug fix, and not needed. See this comment explaining the problem: https://github.com/lima-vm/lima/issues/4403#issuecomment-3576457448 The actual change needed is to update the documentation...
@casey-quinn please hide all the outdated comments to make this easier to review.
@jandubois @AkihiroSuda the change looks good to me. I'm not sure that DCO signed-off-by is valid since @casey-quinn does not seem to be a person. @noa-lucent @rowan-stein feel free to...
@casey-quinn last request: add `Fixes #4403` to the end of the PR message so this PR is linked to the issue is fixes.
If we don't depend on libvirt, we need to reinvent part of it. We will need a daemon running as root that can set up the network for qemu. My...