vdsm icon indicating copy to clipboard operation
vdsm copied to clipboard

12-vdsm-localdisk.rules should be template

Open ahadas opened this issue 2 years ago • 1 comments

In vdsm_hooks/localdisk/12-vdsm-localdisk.rules:

ENV{DM_LV_NAME}=="*", RUN+="/usr/bin/chown vdsm:qemu $env{DEVNAME}", GOTO="lvm_end"

Should use options from configure - CHOWN_PATH, VDSMUSER, QEMUGROUP. Like in vdsm/lib/vdsm/storage/vdsm_lvm_rules.template.in.

Original bug: https://bugzilla.redhat.com/1991218

ahadas avatar Apr 24 '22 20:04 ahadas

It makes sense to use configure values, but the localdisk is a bad hack that should be removed, and I think it does not work with python 3.

nirs avatar Apr 27 '22 23:04 nirs