Neenad Ingole
Neenad Ingole
+1 Same happening with Intellij IDE 2018 EAP ``` Error:scalac: Error: key not found: Repository.scala java.util.NoSuchElementException: key not found: Repository.scala at scala.collection.MapLike$class.default(MapLike.scala:228) at scala.collection.AbstractMap.default(Map.scala:59) at scala.collection.MapLike$class.apply(MapLike.scala:141) at scala.collection.AbstractMap.apply(Map.scala:59) at acyclic.plugin.PluginPhase$$anon$1$$anonfun$8$$anonfun$apply$10.apply(PluginPhase.scala:95)...
@vgarvardt could I contribute to this PR if you don't mind?
@shoamano83 could you please create a PR with the changes you did? The code follows a pattern of options as variadic arguments and the required fields are passed as arguments...
I would go with what you have currently implemented, we cannot follow the exact convention of typescript because golang doesn't support optional with default value in the method signature, so...
I would create an example to use playwright-go with godog 👍🏻
@mxschmitt I would like to be a maintainer of this library. I have started contributing to issues and at the same time trying to understand the lib functionality
@Chimerax2 could you please recheck if this issue still exists? Thank you 😄
It is correctly reported. The `intefaces.json` has the following definition for the method [WaitFoRequest](https://github.com/ninadingole/playwright-go-fork/blob/1b26f7a64e3a2cbadd94ca3b25ed9f424ce0ccb4/scripts/data/interfaces.json#L1318) and [WaitForResponse](https://github.com/ninadingole/playwright-go-fork/blob/1b26f7a64e3a2cbadd94ca3b25ed9f424ce0ccb4/scripts/data/interfaces.json#L1322). The typescript version takes the second argument for timeout [here](https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/client/page.ts#L371). This would require a...
I tried to reproduce this issue with a test but didn't get any issues as @sagikazarmark reported. ``` page, err := browser.NewPage() assert.NoError(t, err, "failed to create page") var wg...
Would be happy to contribute to this lib, I am also extensively using this in my projects and have few feedbacks