playwright-go icon indicating copy to clipboard operation
playwright-go copied to clipboard

PageWaitForRequestOptions and PageWaitForResponseOptions are not used anywhere

Open sagikazarmark opened this issue 3 years ago • 1 comments

The above mentioned types don't seem to be used in their respective function calls (WaitForRequest and WaitForResponse).

Looking at the code here confirms that there is no way to set the timeout for those methods (other than setting the default page timeout).

sagikazarmark avatar May 09 '21 12:05 sagikazarmark

It is correctly reported. The intefaces.json has the following definition for the method WaitFoRequest and WaitForResponse. The typescript version takes the second argument for timeout here. This would require a fix on the go-implementation side

There is also the problem with WaitForEvent which is used and it doesn't provide an option to pass a timeout

ninadingole avatar Sep 04 '22 07:09 ninadingole