nimo23

Results 246 comments of nimo23

> I was thinking more about corrections were I guess this method will not help. @francescopeloi For corrections, you can use https://github.com/ta4j/ta4j/blob/df40f73bc3a6f256a3de162cda6daa3a6c458547/ta4j-core/src/main/java/org/ta4j/core/utils/BarSeriesUtils.java#L87

>I believe the original intent was for addTrade to serve as the interface for this functionality, allowing you to update both the price(s) and volume. Thoughts? Yes, the original and...

>A better alternative would be to allow Bar mutation when the bar is still open. Maybe the BarSeries can allow mutating the last bar of the series when the date...

I added `BarSeries#addLastBar`in https://github.com/ta4j/ta4j/pull/1302 to simplify the process to add or update the last bar. Keep in mind that we can also use https://github.com/ta4j/ta4j/blob/56c99df6f9c2f107fff282d74261c393781d66b1/ta4j-core/src/main/java/org/ta4j/core/BarSeries.java#L214 with replace=true to always replace the...

>Remove the endTime Instant from the bar to save memory and return `beginTime + duration`. This invariant only applies to `BaseBars`. For other bar types, you can specify different bar...

>I can keep as you suggest, however the VolumeBarBuilder and the TickBarBuilder are creating BaseBar's. I'd think that this would apply once the Bar has other subtypes, something like VolumeBar...

See also https://github.com/ta4j/ta4j/pull/1214#issuecomment-2481154739

>so this should be a feature available in macOS by default: Yes, unfortunately Apple prohibits changing brightness and using NightShift after using a (custom) display profile other than XDR.

See https://github.com/ta4j/ta4j/blob/master/ta4j-core/src/main/java/org/ta4j/core/indicators/ROCIndicator.java But we should improve this indicator by adding a property to select open, high, low, close and average prices (by enum), e.g. if `ROCFilter.Average` is used, then the...

> think the ROC in its current state does not work for this use case Yes, would you like to extend this indicator and make a PR. Its purpose is...