Niklas Wenzel
Niklas Wenzel
The PR was closed. It would be awesome if someone else could continue the work on the PR.
Thanks for the fix! Would love to see it merged as I ran into the same issue.
Thanks, @saschanaz! I don't think it's a merge conflict. I tried merging it locally and it worked perfectly. I think the GitHub actions bot ran into a network issue. From...
Got it! ~How/where do you want me to push? (This is not my PR.)~ Ah, just saw your edit. I did the following to merge locally: ```bash git clone [email protected]:microsoft/TypeScript-DOM-lib-generator.git...
Thanks for working on this, everyone! :raised_hands:
How about this wording? > You can find the supported Node.js and Electron versions in the [`.github/workflows/build.yml`](https://github.com/WiseLibs/better-sqlite3/blob/master/.github/workflows/build.yml) file.
I noticed that this was reverted in https://github.com/WiseLibs/better-sqlite3/commit/084819aecc2007d975c55acfc7300ccfd82f3b4e. @JoshuaWise Was that on purpose?
Thanks for the super helpful overview! This is great. Could you please upload your example code as a gist made with [Electron Fiddle](https://www.electronjs.org/fiddle)? This allows team members to quickly reproduce...
I believe this comment explains what broke this in Electron v35 on macOS: https://github.com/electron/electron/issues/46602#issuecomment-2793587590
Is this still happening on Electron v34?