Niklas Wenzel

Results 243 comments of Niklas Wenzel

In https://github.com/electron/electron/pull/46762#discussion_r2059043232, we said we wanted to get this fixed before v37 comes out.

More context on why this is a blocker: - v37 introduces a [breaking change](https://github.com/electron/electron/pull/45921) to utility process exit behavior. - Our [docs](https://github.com/electron/electron/blob/dc5efca0f6b4cd8541b4404582d855f6808a7225/docs/breaking-changes.md?plain=1#L17-L28) present code to get the old behavior back....

@0biwan-ops 1: `process.kill()` cannot be called without an argument. `process.kill` is for killing another process. `process.exit` is for killing the current process. https://gist.github.com/nikwen/838469128c6ebcc7b73dfe985a4edb31 ``` node:internal/process/per_thread:217 throw new ERR_INVALID_ARG_TYPE('pid', 'number', pid);...

@0biwan-ops To be honest, I think this is one of the most difficult issues you could pick for a first contribution. The code is complicated due to the V8 and...

Fixed in https://github.com/electron/electron/pull/47469.

An easy way to get started with Electron and TypeScript is to use Electron Forge with a TypeScript template. Since you mentioned Vite, here's the Vite template: https://www.electronforge.io/templates/vite-+-typescript

@htnabe Check this for why the change was made: https://github.com/electron/forge/releases/tag/v7.5.0 I think it's totally fine to use the Vite plugin in Electron Forge despite the label that sounds scary.

Thanks for reporting and including all these details! To debug, the team will need the code of a minimal example Electron application that opens a PDF file. Could you please...

Thanks for the code! If you can put it into a testcase gist with [Electron Fiddle](https://www.electronjs.org/fiddle), that will increase the probability of someone fixing the issue. (It just makes it...

Thanks for checking! I edited the question after I first sent it. (If you were looking at the email notification, you probably didn't see the edit.) What happens when you...