Nikita Popov comments

Results 517 comments of


                                            Nikita Popov

Format-preserving AST transformations TODO

@Juddling It's half-supported. The formatting of the array is preserved, but the new element is added on the same line. There is currently no detection that the array is formatted...

Format-preserving AST transformations TODO

@Juddling I've just landed https://github.com/nikic/PHP-Parser/commit/1c7fd314d182bafd7254ca8d025a4d83a72a2d6a, so this case should now work correctly (that is, use multi-line formatting).

Format-preserving AST transformations TODO

I've released a beta version for PHP-Parser 4.0 (https://github.com/nikic/PHP-Parser/releases/tag/v4.0.0beta1) and plan to create a stable release soonishly. I'd say that at this point, this feature is working pretty well, and...

Format-preserving AST transformations TODO

@eeliu I can't reproduce this issue. The following test passes for me: ```

Undefined offset: -1 in TokenStream.php

Which operation is performed using PHP-Parser here? This code is used by the formatting-preserving pretty printer. Which modification is being performed, if any?

Undefined offset: -1 in TokenStream.php

Do you know which change Rector is attempting to make for that code?

Undefined offset: -1 in TokenStream.php

I tried this test case: ```

Undefined offset: -1 in TokenStream.php

```

Undefined offset: -1 in TokenStream.php

Closing this as there is no self-contained reproducer (using PHP-Parser only).

Even more fluid code generation

Quite a lot here, I'll start with this: ``` php