Nikita Popov
Nikita Popov
This is an error in the node classification, tracked at #500. The reason why it's not possible to pass an encapsed string part directly in the pretty printer is that...
This is now `Node\InterpolatedStringPart` and no longer an `Expr`.
I think this makes sense, but would need some major (backwards incompatible) changes. Especially as properly supporting this would also require changing the structure of lots of other nodes that...
You motivated me to resurrect this: https://github.com/php/php-src/pull/5176 Gonna write an RFC...
Generally this looks reasonable, but I don't think I can merge this into 4.x due to the backwards compatibility break this causes.
Variants of these changes have been implemented for the next major in the meantime.
> I feel like this got stuck but I don't know why. I'd love to get it before version 5 gets released. What needs to be done here to finish...
As it's now one year later, I wonder whether PHP 7.1 is still the right target?
> FWIW you could require PHP 8 and it would still be fine for PHPStan + Rector I'm not sure that would actually work. If I dropped support for old...
I think I'm going to stick with 7.1 for now, for the sake of simplicity. That should affect about zero people.