Nikhil Bhatt

Results 13 comments of Nikhil Bhatt

I want to work on this issue.

I was working on this and updated headers in `const.rb` and `urlmap.rb`. I have a doubt regarding CI pipelines. For example, in this line, it only sends a request. Should...

> I don't think we need to update our tests. That's not the change we're talking about here. > Ok, consistency of test cases part can be covered in separate...

Confirmed the same is case with rails older version. how do we want to take this forward. Minimum code to regenerate (syntax error in erb) ``` ``` This line (493)...

Minimum code to regenerate the issue --> ``` ``` Even if empty spaces are present after closing braces it will result in showing compiled string. ``` ``` **Problem** 1. File-...

> Any idea how we could test this? **If you are asking about testing the branch, here how I done it** Temporary changes 1. cd to puma latest version. 2....

@dentarg can you check this once?

Is there anything remaining in this from my side?

> @nikhilbhatt There is still one failed test [here](https://github.com/nikhilbhatt/puma/blob/return_lowercase_response_headers/test/test_puma_server.rb#L918) could you please fix it. fixed