casa icon indicating copy to clipboard operation
casa copied to clipboard

Add Filters to Reimbursement Queue View

Open DirkCionci opened this issue 4 years ago • 13 comments

What type(s) of user does this feature affect?

  • all casa admins

Description As an Admin, I would like to be able to filter paid and unpaid reimbursements by volunteer, expense type, and date added so that I can see reimbursements by each filter category.

How should it work

  • Filters should be displayed as outlined in mock-up
    • https://www.figma.com/proto/HBcfH4G9W2pD8psX67orhg/CASA-Redesigns?page-id=30%3A267&node-id=32%3A2&viewport=345%2C48%2C0.5&scaling=min-zoom&starting-point-node-id=67%3A202&show-proto-sidebar=1

Acceptance Criteria

  • Results on page should display selected filter options
  • Total at bottom of page updates to the correct amount of all amounts added from selected filter options
  • Filters don't break other functionality of page

QA Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Wednesday 6-8pm Pacific), stakeholder news, and upcoming new issues.

DirkCionci avatar Oct 14 '21 14:10 DirkCionci

I want to work on this issue.

nikhilbhatt avatar Oct 14 '21 18:10 nikhilbhatt

There's no data, it will be hard to add filters yet. Let's wait on https://github.com/rubyforgood/casa/issues/2762 to be done before this one or you will trip each other

compwron avatar Oct 19 '21 02:10 compwron

@nikhilbhatt maybe don't work on this one yet

compwron avatar Oct 19 '21 02:10 compwron

@compwron looks like #2762 is complete, so is this ready to work on? I'd like to take it on

lukenofurther avatar Dec 10 '21 15:12 lukenofurther

@lukenofurther go for it! :)

compwron avatar Dec 10 '21 15:12 compwron

Awesome, thanks! :)

lukenofurther avatar Dec 10 '21 15:12 lukenofurther

This issue has been inactive for 248 hours (10.33 days) and will be automatically unassigned after 112 more hours (4.67 days).

github-actions[bot] avatar Dec 21 '21 00:12 github-actions[bot]

This issue has been inactive for 368 hours (15.33 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

github-actions[bot] avatar Dec 26 '21 00:12 github-actions[bot]

This issue has been inactive for 383 hours (15.96 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

github-actions[bot] avatar Jan 11 '22 00:01 github-actions[bot]

had to revert feature because something was broken

FireLemons avatar Apr 13 '22 02:04 FireLemons

Hi @compwron, thanks for merging my PR in back in March and sorry for the radio silence on my end. I see there was a problem and there was a partial revert. I'm not surprised - the reimbursements view was in quite a WIP state on the PR, with both the new datatable view and the original table visible. Were there other problems with the page? I have some time to work on it again.

cc @FireLemons

lukenofurther avatar May 13 '22 14:05 lukenofurther

@lukenofurther the filters had some problems so we took them out in the meantime- if you have time, we'd love to try again! :)

compwron avatar Jul 30 '22 04:07 compwron

Hi @compwron yeah I saw that. I'll take a volunteer day from work next week or the week after - at the very least that should allow me to break the back of the work

lukenofurther avatar Aug 11 '22 09:08 lukenofurther

This issue has been inactive for 879 hours (36.63 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Sep 17 '22 00:09 github-actions[bot]

This issue has been inactive for 903 hours (37.63 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Sep 18 '22 00:09 github-actions[bot]

This issue has been inactive for 927 hours (38.63 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Sep 19 '22 00:09 github-actions[bot]

This issue has been inactive for 951 hours (39.63 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]

I think if you comment the bot bothers you less

FireLemons avatar Sep 20 '22 02:09 FireLemons