Niklas Mollenhauer

Results 250 comments of Niklas Mollenhauer

Sorry for the very late reply, I'm currently short on time right now. I will push some more example code to the repository soon. This library will be ported to...

Since the exception seems to be a `QueryException`, the response was valid but the server responded with an error code `!= 0`. Could you inspect the exception? It has an...

Are they really moved to the top? Or does this only appear so if you get the notification/response? Looking at this method: https://github.com/nikeee/TeamSpeak3QueryAPI/blob/master/src/TeamSpeak3QueryApi/Specialized/TeamSpeakClient.cs#L359 There isn't even the option to pass...

- We could enable `#nullable` to make the library more null-safe - `System.ValueTuple` and maybe `Microsoft.CSharp` could be removed from the dependencies - What about `System.Runtime.Serialization.Formatters`? - DTOs could be...

That response parser that uses reflection could be re-written to use a source generator.

With TS5 around the corner, it is questionable if some of the work is worth investing. I doubt that TS5 will use the same crappy protocol. At least I hope...

That's what I heard as well, but is that assured? It would actually be pretty pointless, if they'd just copy some UI stuff from discord. So I am assuming that...

Could we still target .NET Standard 1.3? I know it's old, but there are a lot of users using .NET FW. I'll evaluate if we can target Standard 2.0 and...

Before we can review this PR: Which commit is the one containing the big fix? I think we might be able to cherry-pick it if resolving the conflict is unfeasible.