Nik Revenco
Nik Revenco
> I only see the commits and comments, but even if it doesn't affect the main thread, the performance is still a critical point, helix should stay light. Is a...
Update: `gix_blame` can actually return all the blamed regions, great! I am now confident this can be extremely fast (100x what we have right now)
Having complex symbols can add clutter and I really like what the-mikedavis suggested, so here's my take on it: - circle for info `●` - triangle for hints `▲` -...
Imo it's important that the design is consistent. We can't just have one icon try to convey meaning and another is an abstract shape. Or one is filled and the...
> Update: `gix_blame` can actually return all the blamed regions, great! I am now confident this can be extremely fast (100x what we have right now) New performance update! I...
> > The solution is basically that we have a worker and we check it every 0.05 seconds if its done. If not, then try again later. If it is,...
> Now that the blame is being loaded for the full file. Does this open the door for displaying the blame for the full file near the line numbers? Similar...
While testing in debug mode I ran into the following panic from gix-blame ``` thread 'tokio-runtime-worker' panicked at /home/e/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-blame-0.0.0/src/file/function.rs:243:25: #[ UnblamedHunk { range_in_blamed_file: 0..1, suspects: { Sha1(bc0084d071ac53fa460370667cdd8740e7499c76): 0..1, Sha1(e216e9621e73cda1968632cd20595231af5e07be): 0..1,...
I would say this PR is ready now!
> I don't know if I'm missing some configurations, but I am getting an error trying to turn on the blaming. I'm working on C++, under your branch at commit...