Nils Goroll comments

Results 592 comments of


                                            Nils Goroll

Partial support for Cache-Control's no-cache directive

I have marked all resolved conversations as such and at this point I have only the unresolved remarks left open. In general, I am OK with this PR

Partial support for Cache-Control's no-cache directive

To get ahead, I pushed a rebase to https://github.com/nigoroll/varnish-cache/tree/partial_nocache

Partial support for Cache-Control's no-cache directive

Sorry, I guess I had seen an outdated head of your branch. I am currently traveling and it might be that bad connectivity made me draw wrong conclusions.

Partial support for Cache-Control's no-cache directive

> I thought I had done something wrong and I couldn't see the difference... Yes, it was my fault, sorry again.

Partial support for Cache-Control's no-cache directive

bugwash: OK, @dridi please fight any fires before release (edit, bugwash verdict changed)

build: macos compatibility build fixes

@chenrui333 thank you for your patches. Regarding the endianness-related changes, I would like wait what phk thinks, but the `vmodtool.py` change looks simple and clean, so I cherry-picked it. Related...

build: macos compatibility build fixes

> another thing is looks like there is no CI for macos, maybe we should also add one? we would certainly welcome a contribution :) If you would add one,...

build: macos compatibility build fixes

> yeah, you can use `otool` to extract the version info as below: Thank you, I added your recipe

Inconsistency in vtc_http2 parse_hdr

@bsdphk could you maybe have another look? Two reports in this area are still open in coverity: 1605315 and 1605311

Make object expiry scalable

I agree with the previous comment, multi-EXP would be helpful and would allow for specific optimizations. I see this as largely orthogonal to this PR, as we still need an...