Nils Goroll

Results 592 comments of Nils Goroll

> maybe we should also offer the opposite? Yes, some standard function to create `Cache-Control` based on the state of an object could be useful. Bug please let's keep this...

I have updated the PR to also allow `std.rfc_ttl()` from `vcl_backend_refresh`, for which most of the work was to adjust the test case, because I got lured into a rabbit...

from #4423: Should also add `math.approx`, if going ahead.

I have pushed a ready-to-merge update. Compared to the draft, the following has been added: - `math.approx()` implementing a notion of "approximately equal" as per [Comparing Floating Point Numbers, 2012...

bugwash: for `math.strfromd()`, check if using `fmtcheck` is a better option.

On `fmtcheck`: I worked by strfromd(3), which has: > Therefore, unlike snprintf(), the format string does not have a length modifier character. It's just a minor difference, but IMHO it's...

I noticed that I was making the life of reviewers unnecessarily hard by not providing at least a draft of a version without the submodule. So here it is: https://github.com/nigoroll/varnish-cache/tree/vtest_ext_varnish_nosubmodule

bugwash feedback: avoid the extra `vtc_builtwith.so`. Two options: move `cmd_builtwith` to `vtc_varnish.so` as suggested as an alternative above, or move into `varnishd` for use with `-x builtwith ...`. phk wants...

It seems that my explanation of this PR was not good enough, or too long, or whatever, but apparently it is not clear what this PR does and doesn't do:...