build: macos compatibility build fixes
fixes https://github.com/varnishcache/varnish-cache/issues/4299 relates to https://github.com/Homebrew/homebrew-core/pull/223233
@chenrui333 thank you for your patches. Regarding the endianness-related changes, I would like wait what phk thinks, but the vmodtool.py change looks simple and clean, so I cherry-picked it. Related to that, are there any MacOS-specifics on retrieving the version from a shared object? If yes, would you maybe share the respective command to be added here?
Related to that, are there any MacOS-specifics on retrieving the version from a shared object? If yes, would you maybe share the respective command to be added here?
yeah, you can use otool to extract the version info as below:
> otool -s __TEXT vmod_vcs lib/varnish/vmods/libvmod_debug.so \
| awk '/^[0-9a-f]/ {for(i=2;i<=NF;i++) printf "%s",$i}' \
| xxd -r -p \
| strings
18e27f081788b5e5d44c480f6d9749c07d53ddb9
another thing is looks like there is no CI for macos, maybe we should also add one?
another thing is looks like there is no CI for macos, maybe we should also add one?
we would certainly welcome a contribution :) If you would add one, please have a look at https://github.com/varnishcache/varnish-cache/blob/master/tools/vtest.sh. You need to generate an ssh keypair and send your public key to phk (or me, as a backup) to have it accepted for reporting.
yeah, you can use
otoolto extract the version info as below:
Thank you, I added your recipe
np at all, any concern of merging this PR? (we have already applied it on the homebrew side)
I belive this has been fixed: the Mac-Mini VTester is happy.