Nils Goroll comments

Results 592 comments of


                                            Nils Goroll

on removing content-length for 0-length POST requests

@gstrauss avoiding 411 responses is a compelling argument to change the logic to send `C-L` for anything but `GET` and `HEAD`, thank you. This is now in #4340. But FTR:...

on removing content-length for 0-length POST requests

Coming back to VCL control over `C-L:`: `unset xyz.http.Content-Length` and `set xyz.http.Content-Length = "0"` can be made safe by disregarding any body, basically implying `unset xyz.body`. So all we need...

Consistent locking when logging to H2 session vsl

Wouldn't this deserve a separate lock?

Consistent locking when logging to H2 session vsl

better idea found during bugwash: do not take the lock if the tag is filtered, but keep it on the session lock

On cache Miss of request containing "Range: bytes=0-" response status is 200 (should be 206)

This is known, and it is unclear how this scenario could be improved at all. One of the questions is what would be a good value to send as `last-pos`...

On cache Miss of request containing "Range: bytes=0-" response status is 200 (should be 206)

> For consistency with the non-streaming cases, we could consider replying with a 206 in this scenario. Does it help? If yes, 👍🏽

On cache Miss of request containing "Range: bytes=0-" response status is 200 (should be 206)

@imwhocodes thank you for the additional feedback. We have discussed this ticket today during bugwash and the short summary is "we could do better, but are not sure if it's...

fix: do not use `endian` library on macOS

Also see #4339

Add a facility for unlocked director iteration

After rebasing on the newly understood 4e2c50da9b4b66a39191dcc7ea11bc4e3d11ab6c, I have successfully run my stress test on this patch without any issues.

Add a facility for unlocked director iteration

> What I would like to see is a FOREACH macro which does both the start and end Here's a macro which does that: ```c /* * this macro might...