Nils Goroll

Results 592 comments of Nils Goroll

@barracuda156 I am not familiar with MacPorts, could you please give a some pointers on the libumem sources used with it?

@dridi the OP also reported `dlmopen()` missing. I will look

FTR from bugwash: we do not build umem for bsd, phk sais: ``` (15:16:20) phk: critter phk> size storage/varnishd-storage_umem.o (15:16:20) phk: text data bss dec hex filename (15:16:20) phk: 0...

@cartoush IIRC your commit messages and pull requests so far all were extremely terse. Can you please elaborate such that reviewers can easily understand *which* problem you are trying to...

> > Alternatively, why do we not just hand dead pool handling to a worker thread? > > Isn't a CLI hook good-enough for this kind of cleanup sweep? It...

Except for the one or two nitpicks, I like the structure of the patch now. I do not understand which complication @dridi is seeing, IMHO, this is a _simplification_.

@bsdphk two people think this one is ripe

🤔 I am aware of the problem, but is this not a specific jemalloc+THP issue which surfaces exclusively with the `malloc` storage? For cases where the `malloc` storage is not...

I cherry-picked the first commit to master because it improves documentation for the release.

bugwash: @cartoush please make this a jail option. disabled by default is preferred, enabled by default would also work for me, as long as there is admin control at all