Nils Goroll
Nils Goroll
bugwash: * please improve test coverage - even without this patch it was not too good * please test with an actual browser * do we need to reconsider parameter...
The REGISTER idea sounds good to me. Would you be interested in a contribution?
looks like this is unconditionally hardcoded upstream via `platform_pledge_sftp_server` https://github.com/openssh/openssh-portable/commit/4626cbaf78767fc8e9c86dd04785386c59ae0839
side note: the bereq (for example via `varnishlog -g request`) would have been helpful.
I would suggest the following: * rename `MAIN.busy_sleep` to `MAIN.cache_hit_coalesce` * add `obj.was_coalescing` analogous to `obj.is_hitmiss` etc. but regarding the OPs main point, I think that a coalescing (aka waitinglist)...
I am also ok with @dridi's suggestion to consistently rename to `waitlist` instead of `coalesce`, if that was thought to be more descriptive. My personal opinion is that the waiting...
Dridification before squash can be found in eed37cd3621c990a2d6a999381b05ba958fcbe4d
notes from bugwash: * There should be a way for VCL to stop sending `C-L`. my own homework: * understand why the current code works for pass
homework: why does the current code work? ```diff diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c index bbcb3824f..91ec23780 100644 --- a/bin/varnishd/cache/cache_req_fsm.c +++ b/bin/varnishd/cache/cache_req_fsm.c @@ -493,6 +493,7 @@ cnt_transmit(struct worker *wrk, struct req *req) *...