Niel Markwick

Results 42 comments of Niel Markwick

In the short term you can set minSize in your scaling configuration to 800 to prevent it from scaling smaller than that, but I understand that this is not a...

The most recent commit 87a221c is a squash of the existing commits and an update of the commit message so that the breaking change information appears in the changelog

Can you explain why you believe this is necessary to add? The default session pool options in Java are: * MinSessions =100 * MaxSessions = 400 * WriteSessionsFraction = 0.2...

In theory there should never be an inactive transaction left open by SpannerIO. If there is, then it is a bug in SpannerIO. Writes use blind writes by calling [DatabaseClient.writeAtLeastOnce](https://cloud.google.com/java/docs/reference/google-cloud-spanner/latest/com.google.cloud.spanner.DatabaseClient#com_google_cloud_spanner_DatabaseClient_writeAtLeastOnce_java_lang_Iterable_com_google_cloud_spanner_Mutation__),...

Result of out-of-band discussion between @manitgupta and @olavloite - Change the PR such that SpannerAccessor always sets ``` SessionPoolOptions.setFailIfPoolExhausted() ``` to avoid expanding the SpannerIO public API surface while also...

LGTM Precommit fails for unrelated reason in `org.apache.beam.sdk.io.gcp.spanner.changestreams.it.SpannerChangeStreamOrderedWithinKeyIT > restOrderedWithinKey`