autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Update from functions to functions2

Open a5chin opened this issue 1 year ago • 1 comments

Summary

The version of cloud functions written in terraform was 1st gen, so I updated it to 2nd gen. google_cloudfunctions_function->google_cloudfunctions2_function

Why you need this PR

As shown below, the 2nd generation is recommended over the 1st generation in Google Cloud.

We recommend that you choose Cloud Functions (2nd gen) for new functions wherever possible. However, we plan to continue supporting Cloud Functions (1st gen).

https://cloud.google.com/functions/docs/concepts/version-comparison

What I did

The following 2 files have been updated.

  • autoscalse/terraform/modules/autoscaler-functions/main.tf
  • autoscalse/terraform/modules/forwarder/main.tf

FYI

Already tested with our products.

a5chin avatar Jan 30 '24 03:01 a5chin

Can I suggest this go into V3?

alexlo03 avatar Sep 09 '24 18:09 alexlo03

@henrybell if you're looking to cut v3 please consider this one

alexlo03 avatar Oct 10 '24 14:10 alexlo03

/gcbrun

henrybell avatar Oct 21 '24 12:10 henrybell

/gcbrun

henrybell avatar Oct 21 '24 13:10 henrybell

/gcbrun

henrybell avatar Oct 21 '24 13:10 henrybell

/gcbrun

henrybell avatar Oct 21 '24 13:10 henrybell

/gcbrun

henrybell avatar Oct 21 '24 14:10 henrybell

/gcbrun

nielm avatar Oct 25 '24 15:10 nielm

The most recent commit 87a221c is a squash of the existing commits and an update of the commit message so that the breaking change information appears in the changelog

nielm avatar Oct 25 '24 17:10 nielm

/gcbrun

henrybell avatar Oct 25 '24 17:10 henrybell

/gcbrun

henrybell avatar Oct 27 '24 13:10 henrybell

/gcbrun

henrybell avatar Oct 27 '24 13:10 henrybell

Thanks @a5chin!

henrybell avatar Oct 28 '24 09:10 henrybell