Niel Markwick
Niel Markwick
Just to clarify, this bug/FR is just so that the linter recognises the ES6 import _statement_ for json files, not to actually import and lint the JSON. But I understand...
> @nielm Thanks for the PR! I look forward to publishing the enhancements. As this is a samples library, would you be open to making this an "advanced" version of...
Effectively we already have this at the RPC level ```java /** Specifies the commit deadline. This is overridden if the CommitRetrySettings is specified. */ public SpannerConfig withCommitDeadline(Duration commitDeadline) { return...
The setting of the commit deadline timeout predates the per-transactiom commit delay feature, but it has the same effect - limiting the duration that the spanner server can spend processing...
My apologies - I am indeed confusing it with the commit timeout delay... Two comments on the PR - can you add tests in the Write test code not the...
R: @chamikaramj for IO
Commit deadlines for writes have been supported since [2020](https://issues.apache.org/jira/browse/BEAM-9269) at the RPC level and can be set in 3 ways: * using [Write.withCommitDeadline()](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java#L1184) * using [SpannerConfig.withCommitDeadline()](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java#L224) * using [SpannerConfig.withCommitRetrySettings()](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java#L255) The...
Yes, setting commit timeouts on individual transactions is a relatively new feature in the spanner client libraries. However in Beam, you can only set the timeout on the entire Write...
That container repository has been taken down as it had not been updated for many years, and the images within contained multiple critical vulnerabilities. For this particular image `gcr.io/cloud-solutions-images/jenkins-k8s-slave:latest` ```...