Kuba Niegowski

This case is different. While clicking on the disabled button (in Safari) it gets focused but the selection is still in the editable:  But since editable...

> Oh, it's about the outdent 🤦 It's about any disabled button in the toolbar. If the button is disabled we probably should not focus the button on click (but...

The work for this issue and others related is completed in the https://github.com/ckeditor/ckeditor5/pull/16289, and we finalized the round of internal (successful) tests. I encourage everyone to test the PR if...

.

This PR is replaced with #18603.

> But it seems createElement doesn't have a third argument for children. And there's no createContainerElement either. It's very confusing. What I also found surprising is that the "writer" you...

> @niegowski by any chance the recent work in the empty inline elements could somehow solve also this problem? No, it's not related. But this could be related: https://github.com/ckeditor/ckeditor5/issues/12267

I noticed that the color picker feature is also adding a redundant `tabindex` on part of the panel:  

This looks like a duplicate (same reason) as here: https://github.com/ckeditor/ckeditor5/issues/8412.

Firefox case should be fixed by https://github.com/ckeditor/ckeditor5/pull/14418. But Safari has a different case, it does not crash, it simply does not fire the `beforeInput` event in such scenarios.