ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

[Safari] Block quote and Code blocks cannot be deleted when there is no content before them.

Open michalbilik opened this issue 2 years ago • 3 comments

📝 Provide detailed reproduction steps (if any)

Scenario 1:

  1. Open Safari or Firefox.
  2. Go to https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
  3. Delete all content.
  4. Insert Block quote or Code block.
  5. Try to Backspace it.

Scenario 2:

  1. Open Safari or Firefox.
  2. Go to https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
  3. Delete all content.
  4. Choose Style, for instance Heading 1 (with or without slash command).
  5. Try to Backspace it.

✔️ Expected result

Scenario 1: The Quote and Code blocks are deleted.

Scenario 2: After the Backspace the style should be set back to Paragraph.

❌ Actual result

Scenario 1: The Quote and Code blocks cannot be deleted when there is no content before them. https://github.com/ckeditor/ckeditor5/assets/50703222/a0c91aab-f833-4405-98cf-67970317da17

Scenario 2: After the Backspace the style is still set to Heading 1. https://github.com/ckeditor/ckeditor5/assets/50703222/bd19aa75-0e34-4b3a-9a03-4b192a581032

❓ Possible solution

Regression bug from v35.3.0. Works fine for Chrome.

For Firefox when there is no content the Backspacing is broken. So this issue and issue #14050 might be related.

📃 Other details

  • Browser: Safari Version 16.5 (18615.2.9.11.4)
  • OS: macOS 13.4 (22F66)
  • First affected CKEditor version: 35.3.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

michalbilik avatar Jun 15 '23 10:06 michalbilik

Firefox case should be fixed by https://github.com/ckeditor/ckeditor5/pull/14418. But Safari has a different case, it does not crash, it simply does not fire the beforeInput event in such scenarios.

niegowski avatar Jun 19 '23 15:06 niegowski

DUP here: https://github.com/ckeditor/ckeditor5/issues/14489

niegowski avatar Jun 28 '23 18:06 niegowski

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Jun 29 '24 03:06 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Jul 30 '24 03:07 CKEditorBot