Kuba Niegowski

Results 51 comments of Kuba Niegowski

This is happening only in manual tests in Safari. Looking at the console you can see: ![Screenshot 2024-02-22 at 18 13 58](https://github.com/ckeditor/ckeditor5/assets/1232187/82472190-c1eb-4beb-b2c3-cef8fda8450c) This indicates that CSP is enabled in this...

This is happening because this code can't resolve proper client rect and falls back to parent container bounding rect: https://github.com/ckeditor/ckeditor5/blob/cfab99d31251d7da34698ca267151fdefe150d6e/packages/ckeditor5-utils/src/dom/rect.ts#L386-L407

After a deeper checking, I noticed that the `range.getClientRects()` has a problem resolving screen coordinates if the range is not attached to any text node. In the case of `[]`...

Simplest reproduction (with GHS enabled): ```html foobar ```

> @niegowski do you remember what was the reasoning here? Looks like we just missed it. Also, the comments look like not finished.

This is working as expected. We did not want to force plugin developers to augment `PluginsMap` and `CommandsMap` so we added a fallback for not registered plugins and commands: https://github.com/ckeditor/ckeditor5/blob/e40ee9cdef3ff420bb6454bf0e209c65e0bf187c/packages/ckeditor5-core/src/plugincollection.ts#L648-L650...

Looks like the content is converted into a massive paragraph with soft breaks. Maybe we should do some optimizations there. I'm not sure if this is the real cause. It...

The `contenteditable="false"` attribute is set by the `toWidget()` helper (not the `createContainerElement()`). You could remove the attribute inside the downcast converter: ```js conversion.for( 'editingDowncast' ).elementToElement( { model: 'simpleBlueBlock', view: (...

We were researching this issue. The problem is that for this language, the browser is not firing the `compositionend` event after typing `ygap`, instead it moves the selection forward, in...

> @niegowski can we report this issue to the Chromium with the reproduction steps? Reported to Chromium: https://issues.chromium.org/issues/344767735