nicolasburtey

issue from upgrading https://github.com/GaloyMoney/blink-mobile/commit/826b2297fa12c20682cce39e78545a35378bb81a#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R105

if you try again today, are you able to do the next section? maybe this something we need to clarify, but only one section can be done per day

I quickly skim through the PR, first comments are: - there are no tests. we need tests for something that is one of the most critical point in the app:...

> I'll add the tests once the logic is approved that is fine, but tests are often the best way to make explicit what the logic aim to be >...

@rudyblink screenshots are always helpful, ie: in addition to the "4. See Error"

I have limited context in my head on where we are with the keystore right now. maybe @UncleSamtoshi have some more context to share. You should decide which trade off...

another key aspect to keep in mind is to the upgrade path for existing user. we don't want them to having to log back in when we do this upgrade

> [pulkit-999](/pulkit-999) hey pulkit-999, thanks for making this PR! first thing is we use conventional commit in our repos: https://www.conventionalcommits.org/en/v1.0.0/ I can have a deeper look when the tests are...

that's a good input thanks cc @agbegin @designsats for our next pull focus on notification/client interaction.

https://clnbits.diynodes.com/lnurldevice/HhY7oUsimdWJcnSTCnQPDA currently doesn't load on my end it's not enough to display the content of the link on payment confirmation (keep it in the mobile app)? it should be save...