nicolasburtey

types missing?

8

I'm losing types suggestion from Visual Studio Code if I use EStyleSheet. Do I need to install anything beyond "react-native-extended-stylesheet" to get the types as I have them with StyleSheet?...

Description for invoices is not mandatory?

7

Bolt11 stipulates that: ``` MUST include either exactly one d or exactly one h field. if d is included: MUST set d to a valid UTF-8 string. SHOULD use a...

signet support

4

[signet support](https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/networks.js) is missing from the library (this is generating typescript error here: https://github.com/GaloyMoney/galoy/blob/main/src/domain/bitcoin/onchain/tx-decoder.ts @openoms @dolcalmi)

Update keychain-mobile.js

1

I believe this._RNKeychain.WHEN_UNLOCKED_THIS_DEVICE_ONLY is returning null instead of the right enum it probably falls back to the default state, which is Keychain.ACCESSIBLE.WHEN_UNLOCKED more can be read here: https://github.com/oblador/react-native-keychain

some is_pending are true but should be false

6

doing a `await lnService.getClosedChannels({lnd})` and looping over the close_payments array. I have this result on one of the item: ``` { ... close_transaction_id: '56606548dd251395d67a41a355bc54aa40d1061bb065e81c403815e3506c746d', ... close_payments: [ { is_paid: false,...

types for typescript

14

for people using this library for mission-critical operations, types would be a great addition, as relying on types will proactively reduce errors / potential loss of funds.

need to be able to unregister event

22

I'm using jest with subscribeToChainAddress One of the issues I'm running into is that subscribeToChainAddress is creating a eventEmitter internally, and add some event listener to it. Because those event...

feat: upgrade to graphqlws

1

fix #1365, plus some security consideration using the old library: https://github.com/enisdenjo/graphql-ws/issues/3 I ran into issues when I was importing both `subscriptions-transport-ws` and `graphql-ws` at the same time. instead of trying...

how does the 2 prices feed differ?