Nico Weber

Results 83 issues of Nico Weber

#23024 apparently took the runtime of `Meta/test_pdf.py ~/Downloads/0000` from 1 minute to 5 minutes. I don't pay attention for _one_ second and someone (also me) makes things so much slower,...

regression
performance

No behavior change (except for more granular errors – but in practice everything seems to be group 4).

✅ pr-community-approved

No behavior change, just more granular "not implemented" diagnostics.

👀 pr-needs-review

This is very similar to SimpleFont::draw_string() for now, but it'll become a bit different when we add support for vertical text. CIDFontType now only needs to draw single glyphs. Neither...

👀 pr-needs-review

These arrays store SIDs ("String IDs"), so give them that type now that we have to_array() and it's easy to do. No behavior change.

👀 pr-needs-review

Almost there! But no behavior change yet, since we don't pass CID-keyed CFF data into the CFF parser yet. The diff isn't as big as it looks: The first commit...

👀 pr-needs-review

Makes this code look like the corresponding code in the ScaledFont ctor. Similar to the last commit on https://github.com/SerenityOS/serenity/pull/20084. No behavior change.

👀 pr-needs-review

Together with the already-merged https://github.com/SerenityOS/serenity/pull/23122, https://github.com/SerenityOS/serenity/pull/23128, https://github.com/SerenityOS/serenity/pull/23135, https://github.com/SerenityOS/serenity/pull/23136, https://github.com/SerenityOS/serenity/pull/23162, and https://github.com/SerenityOS/serenity/pull/23167, https://github.com/SerenityOS/serenity/pull/23179, https://github.com/SerenityOS/serenity/pull/23190, https://github.com/SerenityOS/serenity/pull/23194 this adds initial support for rendering some CFF-based Type0 fonts :^) There's a long list of...

👀 pr-needs-review

From a LibPDF point of view, this is a _huge_ progression: Before this, 303 of my 1000 test files rendered without any diagnostics (which doesn't mean that they look 100%...

👀 pr-needs-review

Of my 1000 test files, 73 have stream Type0 truetype fonts with stream CIDToGIDMaps. This makes that work. (With this patch, the number of files in my 1000 test files...

👀 pr-needs-review