Nicholas G Reich

are we still using the baseline_eligibility column in the *_eligibility files in ensemble_metadata?

1

if not, can/should we delete it? Also, if q10/non-decreasing quantiles is not a check for "inc" targets, then can/should we remove it from those files?

create a proper title page for the book

2

I suggest creating a more proper title/intro page for the book. Right now when you load the index page for the book, it shows you the quickstart. But there is...

Add clarification to filtering sections

1

https://mlr3book.mlr-org.com/fs.html#fs-calc I suggest adding a bit more detail to this section to make it easier to follow and understand. - in the example, explain what JMIM/CMIM means for the uninitiated....

would be useful for folks who would like to read up more on the seminal literature of this idea. https://mlr3book.mlr-org.com/nested-resampling.html

https://mlr3book.mlr-org.com/nested-resampling.html#nested-resamp-exec In section 3.3, it is really helpful to revisit the example from earlier in section 3.1. However, it would be even more helpful, now that nested resampling has been...

Section 2.5.5: I recommend adding at least one sentence about each of the figures, just describing what the plot is, even if it seems obvious. In particular, for the ROC...


where are the shape files stored?

3

I've been trying to adapt some of your code for a different project and am trying to figure out how you reference the shapefiles in the `cdc_basemap()` function. Where are...

clean up travis scripts

3

- [ ] remove unused travis scripts - [ ] move used travis scripts to GitHub Actions workflows folder