Nick Charlton

Results 152 comments of Nick Charlton

Thanks for opening this! Yeah, I was suspecting this might be the case. I'm not sure if we can (or maybe I mean should?) do anything about this until some...

Thanks! That's helpful. I think our eventual solution here is going to be to split it into an npm package too. I've been thinking about how to update in such...

Hmm, interesting. I've seen this in the past and it seems much worse now. I just pushed up this branch with a potential solution. I'm going to run it a...

That branch did no good and I'm not necessarily convinced that spending much time on it is worthwhile. @gathuku, hmm, good question. I don't see why you wouldn't in principle...

@tabfugnic, do you think you'd be able to fix the conflicts on this?

Yeah, this is something we've not implemented yet but would be good to do. Is it just search where you see this fail, or are there other problems with `alias_attribute`?

Oh, no, I mean: Did you see any other problems apart from this one relating to search with `alias_attribute`?

Thanks for jumping in and doing this. I've been keen to do this for the last few weeks, so I'm glad you've opened a PR about it. [@dcyoung-dev has a...

If you're still having problems, I'd recommend opening a new issue, so that we can keep this PR related to adding webpacker only.