Nick Charlton

Results 152 comments of Nick Charlton

Hi @namiwang! Would you be able to provide an example app where I can see this happening? Which version of `administrate` are you using?

This seems like a good idea. 1. Do you think you'd be able to write some tests for this? 2. And create a `docs/` entry, too?

@jason-uh You can replicate those failing specs by doing: ```sh appraisal rails42 rspec spec/administrate/views/fields ``` It's a regression from elsewhere, so I'd not worry too much for your specific PR.

@pablobm, do you think you could rebase this? I merged in #1941 and I can't work out how to combine them!

Yeah, they're pretty rough! I didn't even know where to start when I tried myself!

Yes, definitely! I've been a bit absent from the project recently so I imagine we've merged in a lot in my absence but I'll make some time to sort out...

I've just [released v0.18.0](https://github.com/thoughtbot/administrate/releases/tag/v0.18.0). Have fun!

This is neat! I tidied up the default workflow so that it's a lot smaller. It's highlighted one issue we should fix in: `spec/example_app/app/models/doc_page.rb:7` https://github.com/thoughtbot/administrate/security/code-scanning/1

I do see value in this being implemented in the future. But it's not something I'd be likely to include until we're past 1.0. I'd like to hope we can...