Nick Charlton

Results 152 comments of Nick Charlton

This fails on Ruby 2.6 on CI (only) and I cannot work out why.

I wonder if we were getting the reasonably regular failure here and I rebased it? I'm going to do that again, see if it still passes and look back at...

Okay, coming back to this now by undoing it so it goes back to the feature working as it was supposed to.

This looks good! Do you think there's a way we can write a spec for this?

Yeah, I'd like to see something which fails without us providing `resources` like is done here.

I think that we should test the implementation in some form of unit test and not rely on the feature spec to catch it. There's already an existing helper spec...

@jondkinney, is this something you'd be able to look at again?

Oh, interesting! I don't think I've tried a subdomain for many years. I wonder if a configurable list is the best option here. Would you be able to provide an...

I'd support the idea of removing strong parameters as the right solution here. Is this something you might be able to take a look at, @naps62?

Thanks for looking into this! Yeah, agreed. It does look a little weird. I think my biggest concern here is opening up ourselves to a security vulnerability because we’re needing...