nickajacks1

Results 74 comments of nickajacks1

I think if the developer went out of their way to set the specific version, we probably would want to let that take precedence. By setting the version, you're really...

@ldez would it be acceptable to change the viper key delimiter in the config to something else, like "::"? If this has happened twice already, I see it happening again...

Do you recall what broke when you changed the delimiter? I don't see `viper.Get` being used anywhere, and if the delimiter is something obscure enough, we could all but guarantee...

I see that `assert.ErrorContains(t, err, "not found")` is discouraged in favor of `ErrorIs`. I agree with that guidance when it's an option, but sometimes errors are unexported, meaning you have...

3/9: Moved some more methods from Ctx to Request. Rebased.

3/17: Rebase. Moved more trivial methods to Request.

Hi @gofiber/maintainers Sorry this is taking so long. I've reached the first major milestone - the Request API is fully moved over to the Request type. I'd like to get...

Even though Express has Locals as part of the [res API](https://expressjs.com/en/api.html#res.locals), I feel like it makes more sense to keep it as part of Ctx since it doesn't inherently have...

Ok, the Response API is fully moved over. Some remaining work: I didn't move Redirect to the Response API yet. The Redirect API has some dependencies on DefaultCtx that requires...