nickajacks1

Results 74 comments of nickajacks1

I was thinking, is it actually that useful to make Request and Response interfaces if Ctx is already an interface and can thus be expanded instead of Request/Response? If we...

> I am interested in learning more about the approach of expanding the Ctx interface for custom extensions, instead of introducing separate Request and Response interfaces. Could you please explain...

Marking as ready for review. If it is decided to make Request and Response interfaces, I will update the PR. Regarding the docs, I think it might be better to...

Finished docs in time, so I added them to this PR after all. I'd like some criticism on how I updated the docs. I took the approach of keeping everything...

@efectn > For example, if i've updated SendString, it means i'll have different behaving resp and ctx methods Yeah, and this would be a problem whether or not Response is...

Update, fs.FS support seems to be in fasthttp now. valyala/fasthttp#1640

@arp242 What about leveraging GOOS build tags to limit which events can be used? You could have a file or package for windows specific events, one for inotify specific events,...

I understand that the channel may be set to nil to prevent a panic, but is it really valid to call Shutdown twice in the first place? Couldn't it instead...

> Would this change be more useful to more people if when `contains` is a slice or array of the same type as `s`, then the assertion checks that the...

Here's an example of what tagalign will enforce: ```go type Request struct { QueryParam string `query:"query_param"` HeaderParam string `header:"header_param"` BodyParam string `form:"body_param" json:"body_param" xml:"body_param"` } ``` ^ it will complain...