Nickolay Olshevsky
Nickolay Olshevsky
@TJ-91 Thanks, I'll make a review. I retastarted failed CI runs, there are some issues which rarely happens on random occassions/random data (like this one, particularly hit on Windows: https://github.com/randombit/botan/issues/3812...
> done 👍 Looks like there are some memory leaks in PQC tests. Other seem to be just random failures, which happens sometimes.
> The leaks seem to be fixed now Should be good to go now, thanks!
> > Thought it would be faster... > > Is it actually faster now? :P I mean faster transition to C++ from all the anonymous unions, char * and suchlike...
@ronaldtse @antonsviridenko ping for review. Spend a lot of time on debugging on some test failure but separated it to the issue #2192 as too much time was spent on...
Fixed via #2179.
@dkg not sure about the exact date, but the only missing thing was Botan 3.3.0 support fixes, but now we have additional issue #2198. That should not take a lot...
@ronaldtse Should we allow the release with failing codecov? I doubt that It would be an easy task to incorporate all coverage improvements into this release.
@maxirmx do you have any idea why macOS job fails on error related to absence of c++20 support, given that it is passed via command line? Old toolchain? Anyway, #2211...
@maxirmx Thanks for the hint. Looks like 'Ranges' feature, requiring the XCode 14.3, is the root cause. So Including commits from #2211 should be a good solution.