Release v0.17.1

[ni4]

Just minor FFI API update, required by Thunderbird. Fixes #2189

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 90.99099% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 81.40%. Comparing base (0401f9c) to head (4f37e12).

Files	Patch %	Lines
src/lib/crypto/rsa_ossl.cpp	90.62%	9 Missing :warning:
src/lib/crypto/dsa_ossl.cpp	90.56%	5 Missing :warning:
src/lib/crypto/elgamal_ossl.cpp	68.75%	5 Missing :warning:
src/lib/crypto/ec_ossl.cpp	91.66%	4 Missing :warning:
src/lib/rnp.cpp	81.81%	2 Missing :warning:
src/librepgp/stream-parse.cpp	0.00%	2 Missing :warning:
src/lib/crypto/backend_version.cpp	50.00%	1 Missing :warning:
src/lib/crypto/bn.h	95.45%	1 Missing :warning:
src/librepgp/stream-armor.cpp	66.66%	1 Missing :warning:

Additional details and impacted files

@@               Coverage Diff               @@
##           release/0.x    #2190      +/-   ##
===============================================
- Coverage        83.48%   81.40%   -2.08%     
===============================================
  Files              159      105      -54     
  Lines            31957    23420    -8537     
===============================================
- Hits             26679    19066    -7613     
+ Misses            5278     4354     -924     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dkg]

Is there a schedule for this release?

[ni4]

@dkg not sure about the exact date, but the only missing thing was Botan 3.3.0 support fixes, but now we have additional issue #2198. That should not take a lot of time as well.

[ni4]

@ronaldtse Should we allow the release with failing codecov? I doubt that It would be an easy task to incorporate all coverage improvements into this release.

[ronaldtse]

@ni4 the timeliness for this release is more important than codecov right now, let's get it going.

[ni4]

@maxirmx do you have any idea why macOS job fails on error related to absence of c++20 support, given that it is passed via command line? Old toolchain? Anyway, #2211 is aimed to fix this.

[maxirmx]

@maxirmx do you have any idea why macOS job fails on error related to absence of c++20 support, given that it is passed via command line? Old toolchain? Anyway, #2211 is aimed to fix this.

I cannot give exact answer without playing with it but I guess it is related to the version of XCode (and SDK) in use. Depending on macos version GHA runner may have difefrent XCode version selected by default For example, macos-12 runner has XCode 14.2 selected and macos-14 runner has XCode 15.0.1

We may want to use https://github.com/maxim-lobanov/setup-xcode to ensure consistency (not it uses defaults to foster flexibility)

Also c++20 support is somewhat vague. Looking here https://developer.apple.com/xcode/cpp/#c++20 I cannot say what version is required to ensure C++20 support

[ni4]

@maxirmx Thanks for the hint. Looks like 'Ranges' feature, requiring the XCode 14.3, is the root cause. So Including commits from #2211 should be a good solution.

[ni4]

Okay, looks like I just wasted time trying to fix codecov/project CI check. So let's finally make a release.

[ronaldtse]

Thanks @ni4 !

[ni4]

Thanks all, let's make a release!