rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Refactor pgp_key_search_t

Open ni4 opened this issue 1 year ago • 5 comments

Another one on the C++-transition way.Thought it would be faster...

ni4 avatar Jan 31 '24 12:01 ni4

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (9fd1893) 77.26% compared to head (e40c4ff) 77.29%.

Files Patch % Lines
src/lib/key-provider.cpp 89.41% 9 Missing :warning:
src/lib/rnp.cpp 93.67% 5 Missing :warning:
src/lib/types.h 88.88% 1 Missing :warning:
src/librepgp/stream-parse.cpp 88.88% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   77.26%   77.29%   +0.02%     
==========================================
  Files         194      194              
  Lines       37751    37692      -59     
==========================================
- Hits        29170    29135      -35     
+ Misses       8581     8557      -24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 12:01 codecov[bot]

Thought it would be faster...

Is it actually faster now? :P

antonsviridenko avatar Feb 03 '24 21:02 antonsviridenko

There is some conflict, probably caused by the recent merged PR...

antonsviridenko avatar Feb 03 '24 21:02 antonsviridenko

Thought it would be faster...

Is it actually faster now? :P

I mean faster transition to C++ from all the anonymous unions, char * and suchlike internal stuff :) I'll rebase and fix errors and ping you back for review, thanks!

ni4 avatar Feb 04 '24 12:02 ni4

@ronaldtse @antonsviridenko ping for review. Spend a lot of time on debugging on some test failure but separated it to the issue #2192 as too much time was spent on it.

ni4 avatar Feb 17 '24 19:02 ni4