Nick Guerrera

Results 25 comments of Nick Guerrera

When this runs in prodcon is it using the corefx/coreclr that was built before it?

No, string overloads operator ==(a, b) to be the same as String.Equals(a, b)

Interesting take. Treating that expression as object equals would be a bug in FluentAssertions. Seems like we should dig in, verify that, and report it to them if we can...

It looks to me like FluentAssertions uses `Expression.Compile()` so if there's a bug in the interpretation it would be there. @tannergooding Repeating my question: Does prodcon execution of these tests...

@mmitche No, it doesn't get a just-built copy, or no you're not the better person to ask? ;)

I believe the problem with slns was first clearly identified with those famous diagrams. :) Yes, we should warn. In 3.0, we should either disallow it or actually make it...

This is not as simple as it might seem. `dotnet publish` doesn't explicitly set the configuration to Debug. It just does what msbuild /t:Publish does without a /p:Configuration=X argument. That...

There are a lot of different ways to interpret that requirement. My above comment demonstrates why changing dotnet publish to be equivalent to today’s dotnet publish -c Release is very...

Possibly. We could set /p:RunningDotNetPublishWithDefaultConfig=true. And change above based on that. Or something. It would mean that dotnet publish and msbuild /t:Publish are different, though.

Just to set expectations, I think we’re way too late for 3, but happy to explore this for 5.