Nick Guerrera

Results 25 comments of Nick Guerrera

@benaadams Sorry, I don’t work on this project or .NET anymore. It’s been five months since I left so I don’t know if there’s been any development on this.

@(EmbeddedFiles) get passed to /embed

Just pointing out again (see also https://github.com/dotnet/roslyn/pull/15256#discussion_r88746143) that `/embed` is currently only supported if the pdb being produced is portable. The design for embedded source accounted for Windows PDBs as...

VSLANG is sufficient for CLI and VS since we set that when the language is overridden by means other than VSLANG.

It might be interesting for msbuild to do what CLI does and re-export other things like PreferredUILanguage. This would give the same compiler localization as dotnet build if you configure...

@rainersigwald This is exactly what I had in mind when I wrote: > (Now, that actually overlaps with another feature that's evolving and we will likely land in a place...

> This could be equivalent to setting DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR global.json selects the full .NET Core SDK (CLI) used, not just the msbuild SDKs. We don't even have a resolver when we're...

You need Microsoft/msbuild#1310 to be fixed in order to make this change and get binding redirects for a test library.

(Moving https://github.com/dotnet/sdk/issues/387#issuecomment-265608133) This will work fine if you build using desktop MSBuild / Visual Studio, but .NET Core MSBuild has this. This can be worked around with a custom target...

@rainersigwald Thoughts? Should msbuild be more lenient about culture names to allow for custom cultures? I'm not too keen on relying on the build machine having registered a custom culture,...