Seonggon Namgung
Seonggon Namgung
@deniskuzZ , it seems that I don't have a permission to reopen this PR. I rebased and force-pushed my branch recently so there was a difference between the PR's head...
@deniskuzZ , I rebased the branch.
The patch seems reasonable. LGTM
@deniskuzZ , the changes seems reasonable, but we need a reproducing query to verify the patch. Let me see if I can write one.
I reproduced the same issue by running the following query on 10TB dataset. I'll share a better version that works on TestMiniLlapLocalCluster later. ``` set hive.tez.dynamic.semijoin.reduction=false; with a1 as (select...
@ramesh0201 , I write a qfile that verifies your patch. I tested it using TestMiniLlapLocalCliDriver and checked that your patch solves the issue. If you want, you could include the...
I have investgated this issue for few days and conclude that the patch is sufficient to solve this issue. This issues happens when a query plan contains a diamond pattern:...
Just for your information, we tested this patch using TPC-DS queries 1-25 on a 10TB dataset. The total execution times were similar, though query 17 became slower (54s → 94s),...
I have checked that the patch enables BMJ with a subset of bucket columns, and the patches looks good to me. I left a few minor comments.
I think this is a reasonable approach. Regarding the `isTez`/`isLlap` issue in `VectorGroupByOperator`, I'm inclined to use `isTez` and drop `isLlap`, as `VectorGroupByOperator` checks overall heap usage via `gcCanary`, not...