Seonggon Namgung

Results 31 comments of Seonggon Namgung

> To avoid them, I am wondering if we can have an abstract class that enforces two rules. This is [a sample implementation](https://github.com/okumin/hive/commit/389bb74505a440b3edae664626e09781bd69a96d). > > * Rule A: Any subclass...

@dengzhhu653, > > Sorry, MetaStoreFilterHook is used as HiveMetaStoreAuthorizer or AuthorizationMetaStoreFilterHook. I was searching only for the standalone-metastore project. My bad > > Current we need this in the client...

@okumin, I introduced a new abstract class `NormalizedMetaStoreClient`, which eliminates nearly all overloaded method, following the approach you suggested. All `IMetaStoreClient` implementations, including ThriftHiveMetaStoreClient, now extend `NormalizedMetaStoreClient`, and much of...

> Thanks. As we are cutting 4.1 and we are moving to 5.0 next, I would say we can remove some deprecated methods. I got it. Let me make an...

I have removed 13 deprecated methods from `IMetaStoreClient` and updated the affected test cases accordingly. There are still 20 deprecated methods remaining, which are widely used in the current codebase....

Hi @abstractdog. I looked for our documentation to reproduce the situation we met, and unfortunately, there was insufficient information about this issue. To write a qfile from scratch, I need...

@deniskuzZ , Thank you for your advice. I tried to reproduce the issue using `TestTezTPCDS30TBPerfCliDriver`, but I couldn't observe any query plan changes so far. I followed these steps to...

Thank you to @abstractdog and @deniskuzZ for reviewing the patch. After studying the issue again, I have concluded that the proposed patch is insufficient to fully address the issue, so...

@deniskuzZ , I checked sonar and resolved 3 out of 6 reported issues. The remaining issues are not resolved because of the following reasons: 1. https://github.com/apache/hive/blob/612afeb8d7268ebc46cacd44651795bb7e5f999e/ql/src/java/org/apache/hadoop/hive/ql/optimizer/UnionDistinctMerger.java#L73 This method uses return...

I failed reproduce the problem with your test on TestMiniLlapLocalCliDriver, and it seems that this issue is fixed by HIVE-27690. Could you check and share your test environment?